Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.2.1 #4280

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Release v4.2.1 #4280

merged 1 commit into from
Oct 15, 2024

Conversation

puckowski
Copy link
Contributor

  • Update files for Release/v4.2.1.

Performed steps from comment on #4237:

  1. Create a branch from master release/v4.2.1
  2. Bump the Less version. (Unfortunately, this is still clunky, it's changed at package.json in root, and in /packages/less/ for historical reasons)
  3. Update the Changelog
  4. Run grunt dist - (Also clunky -- in a perfect world, we would not be committing dist files, but there are also tricky backwards compatibility problems which caused this initially.)
  5. Commit changed files to branch.
  6. Submit a PR to this repo.

Also tried to mirror #3814

I did not change the lock files. Those can be changed once the new version of Less.js is published to npm.

* Update files for Release/v4.2.1.
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Sep 26, 2024
@matthew-dean
Copy link
Member

@puckowski It looks like the mac test keeps timing out here:

Running "shell:runbrowser" (shell) task
http://localhost:8081/packages/less/tmp/browser/test-runner-main.html
TimeoutError: Timed out after 30000 ms while trying to connect to the browser! Only Chrome at revision r982053 is guaranteed to work.
    at Timeout.onTimeout (/Users/runner/work/less.js/less.js/packages/less/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserRunner.js:252:20)
    at listOnTimeout (node:internal/timers:569:17)
    at process.processTimers (node:internal/timers:512:7)

@matthew-dean
Copy link
Member

@iChenLei can you take a look?

@iChenLei
Copy link
Member

iChenLei commented Oct 8, 2024

@matthew-dean This is a macos-specific issue, I think you can merge the PR first, I will investigate and fix this issue later.

@matthew-dean matthew-dean merged commit 09b8f5c into less:master Oct 15, 2024
7 of 8 checks passed
@iChenLei
Copy link
Member

@matthew-dean Hello, sir. Did you forget to release version 4.2.1 to npm?
https://www.npmjs.com/package/less

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants