Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #466 #557

Merged
merged 2 commits into from
Jan 10, 2012
Merged

Fix for issue #466 #557

merged 2 commits into from
Jan 10, 2012

Conversation

kmchugh
Copy link
Contributor

@kmchugh kmchugh commented Jan 10, 2012

Fix for issue #466, allows rhino to work when window has been defined in the asual lesscss engine.

@marceloverdijk
Copy link

+1

I've tested this patch and works perfectly for me.
All compatibility tests (except import; but that's an issue on my side) are working.

Note that I've updated http://code.google.com/p/lesscss4j/ to this patched 1.2.0 version. This project also contains test classes to execute compatibility tests.

@marceloverdijk
Copy link

@cloudhead could you comments when you think this might be included in new less release?
If it will take some time I will release patched version of my project, otherwise I will wait.
After that I will also upgrade the less css maven plugin: http://mojo.codehaus.org/lesscss-maven-plugin/

@marceloverdijk
Copy link

@kmchugh you might also be interested in http://code.google.com/p/lesscss4j/ and maybe http://mojo.codehaus.org/lesscss-maven-plugin/

@cloudhead
Copy link
Member

I'm gonna hot-patch this into 1.2.0 in a sec as I haven't officially announced 1.2.0 yet.

cloudhead pushed a commit that referenced this pull request Jan 10, 2012
@cloudhead cloudhead merged commit 6196a22 into less:master Jan 10, 2012
@marceloverdijk
Copy link

gr8!

@marceloverdijk
Copy link

ps: will the latest 'fix bug in string arguments to mixin call' also be included?
As I have to make sure to update my compatibility tests then.

@cloudhead
Copy link
Member

yes, just updated everything, current master == 1.2.0

@marceloverdijk
Copy link

Great just updated to latest code and all compatibility tests succeed on my side (except the special @media import one)

@kmchugh
Copy link
Contributor Author

kmchugh commented Jan 11, 2012

Great, thanks. Thanks for the pointers as well @marceloverdijk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants