Upgrade jwt dependency #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unixmonkey
reviewed
Aug 6, 2020
scim_rails.gemspec
Outdated
| @@ -18,7 +18,7 @@ Gem::Specification.new do |s| | |||
|
|
|||
| s.required_ruby_version = "~> 2.4" | |||
| s.add_dependency "rails", ">= 5.0", "< 6.1" | |||
| s.add_runtime_dependency "jwt", "~> 1.5.1" | |||
| s.add_runtime_dependency "jwt", "~> 2.2" | |||
There was a problem hiding this comment.
Why not >= 1.5? Is there an incompatibility?
That way people aren’t also forced to upgrade JWT to upgrade this SCIM gem.
There was a problem hiding this comment.
Great point...corrected. Thanks!
rreinhardt9
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
@leesmith Welcome and thanks for your contribution! This change looks great to me; thanks @unixmonkey for the idea to keep that dependency loose since we are backward compatible with 1.5 still currently 🎉
|
@leesmith a new version has been pushed to rubygems with this update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the jwt gem to the latest because jwt version 1.5.x is over four years old.