Remove unused variables in ReadFile (#866)

lestrrat-go · Mar 21, 2023 · c56c192 · c56c192
1 parent 8dd81b1
commit c56c192
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 33 deletions.
diff --git a/jwe/io.go b/jwe/io.go
diff --git a/jwk/io.go b/jwk/io.go
diff --git a/jws/io.go b/jws/io.go
diff --git a/jwt/io.go b/jwt/io.go
diff --git a/tools/cmd/genreadfile/main.go b/tools/cmd/genreadfile/main.go
@@ -71,15 +71,14 @@ func generateFile(def definition) error {
 	o.L(`}`)
 
 	o.LL("func ReadFile(path string, options ...ReadFileOption) (%s, error) {", def.ReturnType)
-	o.L("var parseOptions []ParseOption")
-	o.L(`var readFileOptions []ReadFileOption`)
-	o.L(`for _, option := range options {`)
-	o.L(`if po, ok := option.(ParseOption); ok {`)
-	o.L(`parseOptions = append(parseOptions, po)`)
-	o.L(`} else {`)
-	o.L(`readFileOptions = append(readFileOptions, option)`)
-	o.L(`}`)
-	o.L(`}`)
+	if def.ParseOptions {
+		o.L("var parseOptions []ParseOption")
+		o.L(`for _, option := range options {`)
+		o.L(`if po, ok := option.(ParseOption); ok {`)
+		o.L(`parseOptions = append(parseOptions, po)`)
+		o.L(`}`)
+		o.L(`}`)
+	}
 	o.LL(`var srcFS fs.FS = sysFS{}`)
 	o.L("for _, option := range options {")
 	o.L(`switch option.Ident() {`)