merge develop/v2 to v2 #1164
Merged
merge develop/v2 to v2 #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: typos * fix: yaml typo
* Update httprc to v1.0.6 * Run gazelle update repos
…1151) * Fix missing imports in genjwa These imports are not actually missing in the generated files because the WithFormatCode option adds them automatically. It is better to not depend on this feature in case of identical package names. * Fix typo * Fix documentation * Add IsSymmetric method for signature algorithms Add IsSymmetric method to the KeyAlgorithm interface. Add symmetric indication to element instead of separate map. * Add IsAssymetric method for signature and key encryption algorithms Add IsAssymetric method to the Key KeyAlgorithm interface. Replace symmetric indication of element with a type indication. * Remove IsAsymmetric methods Add comment to IsSymmetric method to indicate custom registered algorithms will always return false. Add comment to the IsSymmetric method of SignatureAlgorithm to indicate the special nature of NoSignature. Remove IsSymmetric from interface and from InvalidKeyAlgorithm. * Add register with options function Add tests for register (with options) functions. * Remove unnecessary RegisterXXXXWithOptions functions Change the RegisterXXXXWithOptions functions to no longer return an error. * Minor tweaks * Tweak comments * Use the underlying WithOptions from Register**** function * remove struct supportedOptions, since it only has one item. it can be re-introduced if there are more features to be added * tweak comment * Fix bazel --------- Co-authored-by: Hannes Kunnen <hannes.kunnen1999@gmail.com>
* Fix typos/mistakes/wording/links in documentation * Revert changing "suboption" to "sub-option" Change pre-existing use of "sub-option" to "suboption". * Accept suggestions
* Apply changes from #1156 to v2 * Avoid problems on 32-bit systems
* Update CI to use go1.20, and use atomi.Int64 * Update go version in go.mod to go 1.20 * stringify the version name
* Bump golang.org/x/crypto from 0.24.0 to 0.25.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.24.0 to 0.25.0. - [Commits](golang/crypto@v0.24.0...v0.25.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update make tidy / gazelle-update-repos * Update bazel settings --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daisuke Maki <lestrrat+github@gmail.com>
The option never worked since v2, but it was kept around, and the documentation sometimes refered to this option, which it shouldn't have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.