Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jws.Sign() to allow detached, unencoded payload #543

Merged
merged 7 commits into from
Jan 12, 2022
Merged

Fix jws.Sign() to allow detached, unencoded payload #543

merged 7 commits into from
Jan 12, 2022

Conversation

lestrrat
Copy link
Collaborator

fixes #541

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2022

Codecov Report

Merging #543 (177685a) into main (5ded25f) will increase coverage by 0.03%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
+ Coverage   72.82%   72.85%   +0.03%     
==========================================
  Files          84       84              
  Lines        9490     9508      +18     
==========================================
+ Hits         6911     6927      +16     
- Misses       1765     1767       +2     
  Partials      814      814              
Impacted Files Coverage Δ
jws/option.go 76.47% <33.33%> (-10.20%) ⬇️
jws/jws.go 77.97% <100.00%> (+0.45%) ⬆️
jws/message.go 82.37% <100.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ded25f...177685a. Read the comment docs.

@lestrrat lestrrat merged commit b361f31 into main Jan 12, 2022
@lestrrat lestrrat deleted the gh-541 branch January 12, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for detached payload in jws.Sign()
2 participants