Fix the tap offset when overlaps is > 0 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes, it works.... |
|
@letsar just checking in is this PR going to be merged anytime soon? |
|
@letsar Would love to have this merged in :) |
|
Thanks for your hard work. It fixed my issue. |
|
@letsar Can you please merge this in? |
|
@letsar please merge this in. Do you need help with the library? |
|
Thank you and sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80
Issue:
Fix:
@letsar let me know if you have any comments about this, I'm open to spend time solving them.
I'm currently needing this to finish a functionality, so having this packed in a future ^0.6.5 (or sth like that) would be awesome!