Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nomal Core 241 unneeded !! (for pwm) #2742

Closed
DittelHome opened this issue Nov 15, 2019 · 5 comments · Fixed by #2744
Closed

Nomal Core 241 unneeded !! (for pwm) #2742

DittelHome opened this issue Nov 15, 2019 · 5 comments · Fixed by #2744
Labels
Category: Build Related to building/IDE/releases Status: Needs Info Needs more info before action can be taken Type: Not a bug Issues that later appeared not to be a bug (e.g. user error)

Comments

@DittelHome
Copy link

Today i tested again pwm with core 2.5.2. Suprise, pwm is working without flackering.
I tried this version:
ESP_Easy_mega-20191113_normal_ESP8266_4M1M.bin

This means, we could/should delete the ESP_Easy_mega-20191113_normal_core_241_ESP8266_4M1M.bin.
@TD-er
Copy link
Member

TD-er commented Nov 15, 2019

That's good to hear.
Can you also test it with the core 2.6.0?
Just to be sure we also don't need core 2.5.2 just for PWM.

Now the only reason to keep 2.4.x is the size of the minimal OTA versions, since later core libs only become bigger and bigger. :(

@TD-er TD-er added Category: Build Related to building/IDE/releases Status: Needs Info Needs more info before action can be taken Type: Not a bug Issues that later appeared not to be a bug (e.g. user error) labels Nov 15, 2019
@DittelHome
Copy link
Author

ESP_Easy_mega-20191113_normal_core_260_sdk222_alpha_ESP8266_4M1M.bin is also working fine without flickering !!

@TD-er
Copy link
Member

TD-er commented Nov 15, 2019

Great!
So we can get rid of those core builds too, when core 2.6.0 can be built directly from PIO without some tricks.

@Misiu
Copy link

Misiu commented Nov 15, 2019

@TD-er this is the related issue for PIO?
Also, core 2.6.1 is out :)

@TD-er
Copy link
Member

TD-er commented Nov 15, 2019

@TD-er this is the related issue for PIO?
Also, core 2.6.1 is out :)

Yep, that's the issue.
And when I tried building 2.6.1 yesterday I had a build issue, will try again.

TD-er added a commit to TD-er/ESPEasy that referenced this issue Nov 15, 2019
@TD-er
[PIO] Cleanup platformio.ini and move to core 2.6.1 as default (letsc…
063d398 
…ontrolit#2742)

Fixes: letscontrolit#2742
@TD-er TD-er mentioned this issue Nov 15, 2019
Merged
TD-er added a commit to TD-er/ESPEasy that referenced this issue Nov 18, 2019
@TD-er
[PIO] Cleanup platformio.ini and move to core 2.6.1 as default (letsc…
0b499cc 
…ontrolit#2742)

Fixes: letscontrolit#2742
TD-er added a commit that referenced this issue Nov 21, 2019
@TD-er
Merge pull request #2744 from TD-er/feature/core261
d32e268 
[PIO] Cleanup platformio.ini and move to core 2.6.1 as default (#2742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Build Related to building/IDE/releases Status: Needs Info Needs more info before action can be taken Type: Not a bug Issues that later appeared not to be a bug (e.g. user error)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PIO] Cleanup platformio.ini and move to core 2.6.1 as default (#2742) TD-er/ESPEasy
3 participants
@Misiu @TD-er @DittelHome