Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pubsubclient lib #4264

Open
uzi18 opened this issue Sep 13, 2022 · 5 comments
Open

update pubsubclient lib #4264

uzi18 opened this issue Sep 13, 2022 · 5 comments
Labels
Category: Controller Related to interaction with other platforms Category: 3rd-Party Related to other tools or libraries cooperating with ESP-easy Type: Enhancement Improve something already present

Comments

@uzi18
Copy link
Contributor

uzi18 commented Sep 13, 2022

@TD-er @tonhuisman When You look at https://github.com/knolleary/pubsubclient/pulls there are tons of stuff already implemented ... into this lib.
@TD-er
Copy link
Member

TD-er commented Sep 13, 2022

Any suggestion on what's being fixed what we need?
The problem is, I did change quite a few things, so updating isn't that easy.

@TD-er
Copy link
Member

TD-er commented Sep 13, 2022

This seems to be the first (useful) merged one which isn't merged into ESPEasy: knolleary/pubsubclient#571

@TD-er
Copy link
Member

TD-er commented Sep 13, 2022

And this one is also useful: knolleary/pubsubclient#568
The rest is either already implemented (due to long waiting PRs I cherry picked) or not really something we're missing.

@uzi18
Copy link
Contributor Author

uzi18 commented Sep 13, 2022 •
edited
Loading

I think it should be converted into module as external fork of original lib. So rest of the world could also make use of it.

@TD-er
Copy link
Member

TD-er commented Sep 13, 2022

For quite some time, Tasmota did use the literal code of the ESPEasy version of the pubsubclient code.

@TD-er TD-er added Type: Enhancement Improve something already present Category: Controller Related to interaction with other platforms Category: 3rd-Party Related to other tools or libraries cooperating with ESP-easy labels Nov 14, 2022
@TD-er TD-er mentioned this issue Feb 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Controller Related to interaction with other platforms Category: 3rd-Party Related to other tools or libraries cooperating with ESP-easy Type: Enhancement Improve something already present
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uzi18 @TD-er