Allow streaming of large messages #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are required to allow for the transmission of large messages through a connected stream. The changes do not have an impact on the class interface and habitual behavior. In particular, it will enable the use of OTA through a stream hooked through the setStream() class method. I've designed such a stream to demonstrate the functionality: https://github.com/turgu1/mqtt_ota_example.git Guy
|
Hi, could you explain a bit more about why the pr is necessary and what changes actually do? You may not have noticed, but the library includes unit tests that this change has broken. |
|
My call!! sorry about that, I've omitted the one line change in the .h file such that the tests would pass... |
|
After my corrective action, testing failed again. The current fail is due to the change that allow for big messages. I thing this is normal because of the change I made. |
|
Hello. I modified the test case on oversized messages to get it pass. |
|
Thanks for the fix - it's appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are required to allow for the transmission of large messages through a connected stream. The changes do not have an impact on the class interface and habitual behavior. In particular, it will enable the use of OTA through a stream hooked through the setStream() class method. I've designed such a stream to demonstrate the functionality: https://github.com/turgu1/mqtt_ota_example.git
The change allows readPacket to get very large messages. At the moment, it is limited to 64Kb messages. Transmitting larger messages would allow to send firmware binary updates through the mosquitto_pub command or any other mean as one single message. The change is limited to the readPacket method. The running length variable is transformed to be an int32 instead of an int16.
Guy