[IRTX] Use parse argument functions for IR TX command arguments

[TD-er]

As mentioned here: #2724 (comment)

[TD-er]

@jimmys01

Can you try this test build?

• ESPEasy_ESP32_mega-20201130-3-PR_3403.zip
• ESPEasy_ESP82xx_mega-20201130-3-PR_3403.zip

[jimmys01]

cmd.length() is missing.

[TD-er]

But that's only needed for substring, right?
parseStringToEnd is doing all the magic for you, including stripping matching quotes if present.
It does also convert to lower case.

[jimmys01]

@jimmys01

Can you try this test build?

* [ESPEasy_ESP32_mega-20201130-3-PR_3403.zip](https://www.dropbox.com/s/rgk4qda90x070xn/ESPEasy_ESP32_mega-20201130-3-PR_3403.zip?dl=0)

* [ESPEasy_ESP82xx_mega-20201130-3-PR_3403.zip](https://www.dropbox.com/s/dayp8wexthknyva/ESPEasy_ESP82xx_mega-20201130-3-PR_3403.zip?dl=0)

give me 30 min

[jimmys01]

Same behavior.
At least for the IRSENDAC command

[jimmys01]

#ifdef P016_P035_USE_RAW_RAW2
          handleRawRaw2Encoding(command);
#endif //P016_P035_USE_RAW_RAW2
          handleIRremote(command);
        }

Also lines 145 to 149 need your special treatment?
I am to sleep deprived right now, I will have a better look tomorow

[TD-er]

Added the changes to those functions too.

[jimmys01]

Works, thank you.

Also the custom_ir build seems broken once more.

xtensa-lx106-elf-g++: error: CreateProcess: No such file or directory
*** [.pio\build\custom_IR_ESP8266_4M1M\ESP_Easy_mega_20201201_custom_IR_ESP8266_4M1M.elf] Error 1

[TD-er]

Yep I noticed.
We're constantly hitting the max. command line limit in Windows.
I will poke the platformIO developers onece more to stress the importance of a work-around on that issue.

[TD-er]

@jimmys01 I managed to make a nice work-around for the longcmd bug.
See: platformio/platform-espressif8266#231

Just performing a few last tests and if those don't show serious issues, I will merge my PR for this so you can build it all again on Windows.

[TD-er]

@jimmys01 I merged the PR so please let me know if you run into build issues again.

Does this PR need anything else or is it now working?

[jimmys01]

just to be sure the, command
IRSEND,RAW2,something,38,something
must be transformed to
IRSEND,'RAW2','something','38','something' ?

[TD-er]

quotes are only needed if the parameter contains a character that can be considered a parameter separator, like:

• , (a comma)
• (a space)

And to make it possible to still use single or double quotes in a parameter, you can chose either of the other quote types to wrap a parameter.

So if you only have parameters that don't have a comma or a space, then you don't need to add quotes.

[jimmys01]

We are good to go! also the Custom IR builds work again!! Extremely good work, it seemed a really tricky bug to solve.
One minor issue is that if you press submit in the following screen

the updated page will be missing the parameters and only hold the first part of the command.

just reporting it because i noticed it, nothing really bad comes out of it.

[TD-er]

@jimmys01
If you ever have "just reporting" feeling itching... Please be aware what it may result into ;)
See the last commit I added to this PR.