Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR] Update IR library to the latest build #3811

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

jimmys01
Copy link
Contributor

No description provided.

@TD-er
Copy link
Member

TD-er commented Oct 15, 2021

Have you tried compiling it yourself?
build (esp8266, custom_IR_ESP8266_4M1M) fails with true compiler erors and after that no other envs were tried by the build process.

@jimmys01
Copy link
Contributor Author

I had compiled it a couple of days ago and now something was added apparently that broke it.. I will investigate

@TD-er
Copy link
Member

TD-er commented Oct 15, 2021

Maybe also try to compile exactly that PIO env, without your own Custom.h

@jimmys01
Copy link
Contributor Author

I made changes to the library to see if it will compile. If the library mainteiner aproves them this will be ready for merge

@TD-er
Copy link
Member

TD-er commented Oct 16, 2021

I made changes to the library to see if it will compile. If the library mainteiner aproves them this will be ready for merge

@jimmys01
Let me know if @crankyoldgit agrees :)

@crankyoldgit
Copy link
Contributor

FWIW, crankyoldgit/IRremoteESP8266#1640 is/will be basically what @jimmys01 has suggested.
I think the root of the issue is a difference in Arudino 8266 framework/platform. e.g. They may have fixed something between 2.6/2.7 & 3.0.2

@TD-er
Copy link
Member

TD-er commented Oct 18, 2021

@jimmys01 Need anything else to update (e.g. lib revision) or can I merge it?

@jimmys01
Copy link
Contributor Author

It is ready to be merged!

@TD-er TD-er merged commit 912c4fe into letscontrolit:mega Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants