Wake/Longpress/Toggle support for Touch-Plugin on compatible ESP32 devices #5202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added extra routine for esp32 s2 and s3 - added option to wake up the esp for supported devices (tested with s3) - added second value "state" for easier handling - failed epically to add a long press event because I am just a simple person, but left the remains for someone else to pick up And as always, please don't stone me. me and c++ are not going to be friends in this life anymore. :) If you agree to the changes i will update the documentatzion accordingly
- added and tested wakeup on ep32 classic
get the actual valuename
- added "toggle state" option (since I am not able to add a long press :) )
- added "long press" event - disabled "Single event with all values" since it is not working with the recent code (suggestions are welcome) but there is also the question if it is necessary
- make all touch pins available on s2/s3
- check if touchpad exists
- reverting T10_to_T14 support
- type of threshold now dependent on model (uin32_t for s2 and s3) - max threshold value now also dependent on the type of esp
- Hopefully fixed compile errors for non-touch ESP32 variants by standardizing the use of uint32_t for the threshold parameter on ESP32 Classic. The value remains limited by P097_MAX_THRESHOLD_VALUE to 4095.
code: - changed order of device settings - added changelog
I am lagging one year behind :)
docs: a little bit of correcting and rephrasing
TD-er
reviewed
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When i resolve conflicts in VSCode and then push it i always have to do a new PR... Sorry, I am still not able to handle this.
Here the text from the old PR:
failed epically to add a long press event because I am just a simple person, but left the remains for someone else to pick uppins 10 to 14 now available for ESP32 s2 and s3they still cause crashesAnd as always, please don't stone me. Me and c++ are not going to be friends in this life anymore. :)
If you agree to the changes i will update the documentation accordingly.
Resolves #5164