Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore postgres dialect #10

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Restore postgres dialect #10

merged 6 commits into from
Mar 29, 2024

Conversation

jsha
Copy link

@jsha jsha commented Mar 27, 2024

In #1 we removed the Postgres dialect for simplicity. Per #7396 we'd like to be able to readily experiment with Postgres, so this restores it.

@jsha jsha requested a review from aarongable March 27, 2024 20:44
@jsha jsha requested a review from a team as a code owner March 27, 2024 20:44
@jsha jsha force-pushed the restore-postgres branch from bfdc9c3 to 9817319 Compare March 27, 2024 20:57
jsha added 3 commits March 27, 2024 14:35
Restore dialect_postgres.go and dialect_postgres_test.go

Restore relevant README sections and interface test.

Restore GitHub Workflow configuration.
@jsha jsha force-pushed the restore-postgres branch from 32436b4 to b0f33e4 Compare March 27, 2024 21:36
@jsha
Copy link
Author

jsha commented Mar 27, 2024

Now with passing tests! :D

aarongable
aarongable previously approved these changes Mar 29, 2024
README.md Outdated Show resolved Hide resolved
gorp.go Outdated Show resolved Hide resolved
@jsha jsha requested a review from pgporada March 29, 2024 19:47
@jsha jsha merged commit 02fd711 into main Mar 29, 2024
6 checks passed
@jsha jsha deleted the restore-postgres branch March 29, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants