apply TypeConverter to args, not just fields #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using custom types in query parameters. It also allows performing custom transformations on standard types (like rounding times to the second).
|
I also ran the new tests cases against main and confirmed they failed. One initial mystery: they failed with this error message: Which is the same error message you'd get if, for instance, you sent a query with a |
|
Ah, needs adjustments to run with postgres dialect and also a fix to the govulncheck test. |
aarongable
reviewed
Jun 14, 2024
jsha
requested review from
a team and
beautifulentropy
and removed request for
a team
aarongable
approved these changes
Jun 17, 2024
beautifulentropy
approved these changes
Jun 17, 2024
jsha
added a commit
to letsencrypt/boulder
that referenced
this pull request
Jun 24, 2024
We believe the MariaDB query planner generates inefficient query plans when a time index is queried using high precision (nanosecond) times. This uses the updated borp from[1] to automatically truncate `time.Time` and `*time.Time` in query parameters. [1]: letsencrypt/borp#11 Part of #5437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using custom types in query parameters. It also allows performing custom transformations on standard types (like rounding times to the second).