-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACMEv2: "orders" field missing in account info #3335
Comments
We should implement this field - @jsha @rolandshoemaker |
https://tools.ietf.org/html/draft-ietf-acme-acme-09#section-7.1.2
https://tools.ietf.org/html/draft-ietf-acme-acme-09#section-7.1.2.1
|
Considering that ACME v2 was scheduled to go live yesterday, is there currently a way to retrieve a list of pending orders? I'm sure you're busy with getting boulder ready, in order to ship ACME v2 for Let's Encrypt, so please don't feel pressured. I just happened to trip over this again. |
@buschtoens We still have not implemented the "orders" field on account objects and we're not considering this a required feature for the V2 launch. I expect it will be a little bit after the launch before we implement it. I recommend that your client maintain the IDs of orders it creates with the The best way to watch for progress is to keep an eye on this issue, particularly when it gets assigned to a milestone for a sprint. Thanks for your patience! |
@cpu, can we expect to see any movement on this anytime soon? The ACME spec draft appears to be quite close to its final form, pending the whole process of making it an actual RFC. While I agree the "orders" field is a convenience, it is still a required part of the spec, yet this has been sitting idle for months now. |
Unlikely. It's a non-trivial amount of work for a convenience and there is still substantial higher priority work to be done in other areas.
@bkromhout PRs are welcome. |
Is there no alternative to tracking the order ids client side currently? |
That's correct. |
RFC 8555 states that: - when an account is successfully created, the server "returns this account object" (section 7.3); - the `orders` field in account objects is mandatory (section 7.1.2). Despite that, Boulder does not returns the `orders` field when an account is created. This non-standard behavior prevented ACMEd from creating account and testing them for existence. In order to allow ACMEd to retrieve certificates from CAs using Boulder, the `orders` field is no longer mandatory and the account existence is tested when the order is requested. letsencrypt/boulder#3335
It'd be swell if Boulder supported this. Pebble does. I've implemented a client to spec, and this is the last step I need to work around. I'm happy to help if I can. |
Edit: Took me a while to figure out where to get the order ID. It's in the "Location" header returned by the call to newOrder. |
@jsha @aarongable @beautifulentropy Can one of you please pick up this issue? Per RFC 8555 this information is mandatory. |
Hi @cowwoc, Appreciate your focus on RFC compliance. Indeed, we sometimes vary from this RFC 8555, more divergences are documented here. Implementing this feature has not been a priority thus far, but we do keep public feedback in mind when deciding what to work on next. Thanks for your patience and understanding! |
I work on an acme client at Akamai and we would really love this feature so that we can understand our account's status better, as well as to keep our open-orders footprint lower! It would help us do more traffic with LE before getting rate-limited, which we would all be happy about. LE suggests in the Rate-Limiting page that if an ACME client builds up a lot of pending orders it knows it will never succeed on, it is encouraged to clear them out by manually attempting open orders' challenges, even if the client knows they will fail. Right now, we don't keep data about every single order and authorization associated with our account, and even though the RFC says Boulder should, Boulder doesn't either... given how the RFC is written, it seems to me like it should be a higher priority for us to get Boulder to be able to make these lists than our client. |
When I POST an empty update to my account URL I get this:
There is no
orders
field as required by https://ietf-wg-acme.github.io/acme/draft-ietf-acme-acme.html#rfc.section.7.1.2The text was updated successfully, but these errors were encountered: