Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS-SNI validation's Dial doesn't use Context #3628

Closed
jsha opened this issue Apr 7, 2018 · 0 comments
Closed

TLS-SNI validation's Dial doesn't use Context #3628

jsha opened this issue Apr 7, 2018 · 0 comments
Labels
area/va kind/bug kind/performance

Comments

@jsha
Copy link
Contributor

jsha commented Apr 7, 2018

Right now this is kind of hard because tls doesn't offer a DialContextWithDialer, but it might be possible in an upcoming Go version: golang/go#18482.

There's also a potential workaround mentioned in that issue by doing the Dial ourselves and then building a tls.Conn on top of it. May not be worthwhile changing for TLS-SNI, but we should do it right for TLS-ALPN.
@jsha jsha changed the title TLS-SNI validation doesn't use Context TLS-SNI validation's Dial doesn't use Context Apr 7, 2018
jsha added a commit that referenced this issue Apr 13, 2018
@jsha
Use a context when dialing for tls-sni-01.
8d67ec2 
Fixes #3628
@jsha jsha mentioned this issue Apr 13, 2018
Merged
jsha added a commit that referenced this issue Apr 16, 2018
@jsha
Use a context when dialing TLS for TLS-SNI (#3648)
a1b98d9 
This allows us to have fast-running unittests without modifying the global state in singleDialTimeout,
which can become a const.

Fixes #3628.

Builds on top of #3629, review that first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/va kind/bug kind/performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsha @cpu