Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit caching of /directory #4814

Open
shred opened this issue May 21, 2020 · 0 comments
Open

Permit caching of /directory #4814

shred opened this issue May 21, 2020 · 0 comments

Comments

@shred
Copy link

shred commented May 21, 2020

Currently, requesting the /directory gives this response header:

cache-control: public, max-age=0, no-cache

A strictly implemented client is forced not to cache the result, but fetch a new copy of the directory every time it is needed. However, the contents of the directory are likely to change very rarely.

Boulder should instead set a reasonable expires header, to reduce unnecessary requests.

This would also help to reduce log volume, see issue #3050. 😉
@shred shred mentioned this issue May 24, 2020
Closed
aarongable added a commit that referenced this issue Dec 13, 2023
@aarongable
Allow ICANN TLDs as registration email domains
6cf2a82 
We currently use the same logic to ensure that domain names are valid for certificate issuance and are valid for being the domain component of a subscriber's contact email address. However, we do not need to be as strict for email addresses: namely, it is possible for a subscriber to have an email whose domain component is exactly an ICANN TLD, while it is forbidden for us to issue a certificate to a name that is exactly an ICANN TLD.

Move the TLD logic out of ValidDomain and into its two callers: willingToIssue and ValidEmail. Slightly modify the logic in ValidEmail to not reject ICANN TLDs.

Fixes #5372
Fixes #4814
@aarongable aarongable mentioned this issue Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shred