Run go generate in Travis #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous command only worked on OS X. This one works on Linux but not OS X. Also add generate phase of test.sh.
| gomock "github.com/golang/mock/gomock" | ||
| time "time" |
There was a problem hiding this comment.
why are these being renamed?
There was a problem hiding this comment.
That's just something mockgen does.
jsha
added a commit
that referenced
this pull request
Apr 25, 2016
* Switch to new vendor style (#1747) * Switch to new vendor style. * Fix metrics generate command. * Fix miekg/dns types_generate. * Use generated copies of files. * Update miekg to latest. Fixes a problem with `go generate`. * Set GO15VENDOREXPERIMENT. * Build in letsencrypt/boulder. * fix travis more. * Exclude vendor instead of godeps. * Replace some ... * Fix unformatted cmd * Fix errcheck for vendorexp * Add GO15VENDOREXPERIMENT to Makefile. * Temp disable errcheck. * Restore master fetch. * Restore errcheck. * Build with 1.6 also. * Match statsd.*" * Skip errcheck unles Go1.6. * Add other ignorepkg. * Fix errcheck. * move errcheck * Remove go1.6 requirement. * Put godep-restore with errcheck. * Remove go1.6 dep. * Revert master fetch revert. * Remove -r flag from godep save. * Set GO15VENDOREXPERIMENT in Dockerfile and remove _worskpace. * Fix Godep version. * Use tools/venv.sh from client repo in integration tests (#1752) * Fix total DNS latency stat (#1751) exchangeOne used a deferd method which contained a expression as a argument. Because of how defer works the arguments where evaluated immediately (unlike the method) causing the total latency to always be the same. * Rework how KeyAuthorization works (#1688) * Enhance error message in NewKeyAuthFromString * va: generate expected response and string compare * NewKeyAuth can return error, handle that... * wip commit * convert ch.KeyAuthorization to string and rename * more wip commit * wip 3 * wip 4 * delete NewKeyAuthorizationFromString * change to ServerInternalProblem * fix compile error * semantic merge conflicts are the worst actually compiled this time. * Replace new error with statsd increment * Parallelise email DNS lookup for new-reg (#1731) * Parallelise email DNS lookup for new-reg * Remove the 1-case switch * context.Context as the first parameter of all RPC calls (#1741) Change core/interfaces to put context.Context as the first parameter of all RPC calls in preparation for gRPC. * Update grpc dep and regenerate caa-checker. (#1761) * Update grpc dep and regenerate caa-checker. The latest version generates a different format. This is a precursor to running go generate in Travis. * Run go generate in Travis (#1762) * Fix go generate command in metrics. The previous command only worked on OS X. This one works on Linux but not OS X. Also add generate phase of test.sh. * Add mockgen to test setup. * Fix github-pr-status output. * Fix envvar style. * Set xtrace. * Fix test.sh * Fix test.sh some more. * Fix mockgen command. * Add dependencies for running `go generate`. * Add protoc-gen-go. * Fix go get command. * Fix generate. * Wait for all. * Fix generate. * Update generated pb. * Fix generate commands for vendored world. * Update documentation for new vendor style. * Update grpc package to latest. * Update caaChecker proto with latest. * Run go generate only over TESTPATHS * See if Travis passes under 1.6 * Switch back to 1.5. * Trim run command. * Run stringer from correct directory. * Move generate command. * Restore and generate * Fix path. * list contents of GOPATH. * Fix stringer by prebuilding. * Try another import path. * regenerate bcode_string. * remove excess package * pull jsha fork of protoc-gen-go that echoes * Echo protoc version. * install from source * CD back. * Go back to normal protoc-gen-go * Fix path * Move protobuf install into test/setup.sh * Move before_install to install. * Set PATH. * Follow 301 with curl. * Shuffle test order. * Swap back test order. * Restore all tests. * Restore 1.5.3 to Travis. * Remove unnecessary wait-or-exit * Generate metrics mock with latest mockgen. * Wrap TESTPATHS in curlies * Remove spurious bracket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${TESTPATHS}instead of TESTPATHSgo getcommand, and add some packages needed bygo generateNote: reviewing and merging #1761 first will make this more straightforward to review.