Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integration not yet written : as it adds change to PA config to add a challenge type: and need certbot side change for write integration test: but unittest wise it mostly works:
currently WFE doesn't send full accountURL into VA, so it tries all accountURL prefix to generate possible challenge subdomain
from looking at test config files second listing is for v2 address so I used it to returned if both subdomain is empty: but it's just guesswork, but there could be better heuristic or edit RFC unto VA to send full URL, but it looks too much passing there for tiny amount of v1 account out there