Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Identifier types over gRPC/db #7316

Closed
wants to merge 6 commits into from

Conversation

orangepizza
Copy link
Contributor

@orangepizza orangepizza commented Feb 7, 2024

in old version there are few places Authztopb or PbtoAuthz / and then input to db identifier types were discarded and upon re-hydrating it codes made new Identifier with type DNS.
while I think it may better to be sent as uint8 type, two identifierType types with different underlying types would be too confusing so it'll sent as string

kinda part of #7311, first two subtasks

@aarongable
Copy link
Contributor

As noted in #7311, we have two other priorities that are prerequisites before we're fully ready to work on IP Identifier things. While our eventual support for IP addresses might look something like this, it's likely not worth adding this now and then sitting on dead code for a few months. I'm going to close this PR; if you want to be part of implementing our major 2024 goals, reach out on the community forum and I'll be happy to chat about where we could use the help!

@aarongable aarongable closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants