Pass Identifier types over gRPC/db #7316
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in old version there are few places Authztopb or PbtoAuthz / and then input to db identifier types were discarded and upon re-hydrating it codes made new Identifier with type DNS.
while I think it may better to be sent as uint8 type, two identifierType types with different underlying types would be too confusing so it'll sent as string
kinda part of #7311, first two subtasks