-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update otel dependencies to v1.27.0 and v0.52.0 #7496
update otel dependencies to v1.27.0 and v0.52.0 #7496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's have this PR update go.opentelemetry.io/contrib to v0.52.0 at the same time. That's part of the same bundled release, and contains the change we need to finish #7235
759f970
to
8cd5eea
Compare
@dependabot rebase |
8cd5eea
to
4d4ee28
Compare
d741b5f
to
4d4ee28
Compare
After spending some time on this it appears that an update to v0.52.0 is going to be a heavy lift that should happen in its own PR. Upgrading this dependency necessitates an update to several others and ultimately breaks the build due to an otel schema change: Dependencies:
Build issue post
Fix for build issue: options := []grpc.ServerOption{
grpc.Creds(creds),
grpc.ChainUnaryInterceptor(unaryInterceptors...),
grpc.ChainStreamInterceptor(streamInterceptors...),
grpc.StatsHandler(otelgrpc.NewServerHandler(
otelgrpc.WithFilter(
filters.Not(filters.HealthCheck()))),
),
}
If you find a way to do this without the heavier lift, I'm all for it, but I'm not seeing an easy win here. |
I'll do it later today. I don't see any point to upgrade to 1.27 here without getting the accompanying 0.52 upgrade that we actually want, and the schema URL is just the same thing as I fixed in the previous PR here. It sucks that these packages are structured such that dependabot can't simply update them correctly. |
Okay, updated the PR to also update the other dependencies, added the fixes for the API breaking changes, and updated the commit description. PTAnotherL! |
Neat, I'm happy you were able to figure out the schema URL issue. |
Directly update:
Indirectly update:
This update breaks some of our existing otel grpc interceptors, but in return allows us to use the newer grpc StatsHandler mechanism, while still filtering out health-check requests.
Fixes #7235