Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ratelimits: Skip Spends on CertificatesPerDomain for renewals #7676

Merged
merged 3 commits into from
Aug 21, 2024
Merged

ratelimits: Skip Spends on CertificatesPerDomain for renewals #7676

merged 3 commits into from
Aug 21, 2024

Conversation

beautifulentropy
Copy link
Member

@beautifulentropy beautifulentropy commented Aug 21, 2024 •
edited
Loading

This bug was introduced in #7669.

Also, make calls to ra.countCertificateIssued() non-blocking like ra.countFailedValidation().

Part of #7664
Blocks #7666

@beautifulentropy beautifulentropy mentioned this pull request Aug 21, 2024
Merged
@beautifulentropy beautifulentropy marked this pull request as ready for review August 21, 2024 16:38
@beautifulentropy beautifulentropy requested a review from a team as a code owner August 21, 2024 16:38
aarongable
aarongable previously approved these changes Aug 21, 2024
View reviewed changes
ra/ra.go Outdated Show resolved Hide resolved
beautifulentropy added a commit that referenced this pull request Aug 21, 2024
@beautifulentropy
Remove changes made in #7676
76ebf98
beautifulentropy added a commit that referenced this pull request Aug 21, 2024
@beautifulentropy
Remove changes made in #7676
27dc3a9
@beautifulentropy beautifulentropy merged commit 4bf6e2f into main Aug 21, 2024
12 checks passed
@beautifulentropy beautifulentropy deleted the ratelimits-ra-isrenewal branch August 21, 2024 19:25
beautifulentropy added a commit that referenced this pull request Aug 22, 2024
@beautifulentropy
ratelimits: Add a feature-flag which makes key-value implementation a…
c9be034 
…uthoritative (#7666)

- Add feature flag `UseKvLimitsForNewOrder`
- Add feature flag `UseKvLimitsForNewAccount`
- Flush all Redis shards before running integration or unit tests, this
avoids false positives between local testing runs

Fixes #7664
Blocked by #7676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongable aarongable aarongable approved these changes

@jsha jsha Awaiting requested review from jsha jsha is a code owner automatically assigned from letsencrypt/boulder-developers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beautifulentropy @aarongable