Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lay the groundwork for supporting IP identifiers #7692

Merged
merged 6 commits into from
Aug 30, 2024
Merged

Lay the groundwork for supporting IP identifiers #7692

merged 6 commits into from
Aug 30, 2024

Conversation

aarongable
Copy link
Contributor

Clean up how we handle identifiers throughout the Boulder codebase by

  • moving the Identifier protobuf message definition from sa.proto to core.proto;
  • adding support for IP identifier to the "identifier" package;
  • renaming the "identifier" package's exported names to be clearer; and
  • ensuring we use the identifier package's helper functions everywhere we can.

This will make future work to actually respect identifier types (such as in Authorization and Order protobuf messages) simpler and easier to review.

Part of #7311

@aarongable aarongable requested a review from a team as a code owner August 29, 2024 23:52
@aarongable aarongable requested a review from jsha August 29, 2024 23:52
@jsha jsha merged commit dad9e08 into main Aug 30, 2024
19 checks passed
@jsha jsha deleted the identifier-pb branch August 30, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants