Add spans around (pre)certificate signing #7707
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beautifulentropy
approved these changes
Sep 13, 2024
beautifulentropy
requested review from
a team and
jsha
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds custom spans around one of the more important parts of the issuance stack - actually signing the (pre)certificates. We only have automatic tracing right now, so this is just a small step towards adding more customization there.
One specific note: I didn't include the regID in the span attributes, though it is in the nearby log lines. I think that's something we likely want to handle holistically (eg, via baggage propagation) rather than one-off in manual spans like this.