Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFE: Suppress logging of probs.PausedProblem #7719

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

beautifulentropy
Copy link
Member

@beautifulentropy beautifulentropy commented Sep 23, 2024

Instead of logging the message shown to the caller, log "429 :: rateLimited :: account/ident pair is paused"

@beautifulentropy beautifulentropy marked this pull request as ready for review September 23, 2024 21:29
@beautifulentropy beautifulentropy requested a review from a team as a code owner September 23, 2024 21:29
web/send_error.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Would you mind adding a test?

web/send_error.go Outdated Show resolved Hide resolved
beautifulentropy and others added 2 commits September 23, 2024 17:50
Co-authored-by: Aaron Gable <aaron@letsencrypt.org>
@beautifulentropy beautifulentropy merged commit 8c009f2 into main Sep 26, 2024
12 checks passed
@beautifulentropy beautifulentropy deleted the suppress-paused-logging branch September 26, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants