Introduce SerialPrefixHex field in CA #7721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jprenken, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
beautifulentropy
requested changes
Sep 30, 2024
beautifulentropy
requested review from
a team and
beautifulentropy
and removed request for
a team
jsha
reviewed
Sep 30, 2024
aarongable
approved these changes
Oct 4, 2024
beautifulentropy
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new SerialPrefixHex field to the CA's config, which takes a two-character hexadecimal string to use as the serial prefix. This matches the way that the OCSP Responder's acceptable serial prefixes are configured, and is easier for human operators to configure than raw integers.
At the same time, change the type of the CA's internal serial prefix from
inttobyte, using the type system to enforce its 8-bit length.Fixes #7213