ratelimits: Use INCRBY instead of SET when a bucket already exists #7782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jprenken, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
|
@jprenken, this PR adds one or more new feature flags: IncrementRateLimits. As such, this PR must be accompanied by a review of the Let's Encrypt CP/CPS to ensure that our behavior both before and after this flag is flipped is compliant with that document. Please conduct such a review, then add your findings to the PR description in a paragraph beginning with "CPS Compliance Review:". |
jsha
previously approved these changes
Nov 1, 2024
aarongable
previously approved these changes
Nov 2, 2024
jsha
reviewed
Nov 4, 2024
beautifulentropy
approved these changes
Nov 4, 2024
jsha
approved these changes
Nov 4, 2024
aarongable
approved these changes
Nov 4, 2024
beautifulentropy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new method,
BatchIncrement, to issueIncrBy(instead ofSet) to Redis. This helps prevent the race condition that allows bursts of near-simultaneous requests to, effectively, spend the same token.Call this new method when incrementing an existing key. New keys still need to use
BatchSetbecause Redis doesn't have a facility to, within a single operation, increment or set a default value if none exists.Add a new feature flag,
IncrementRateLimits, gating the use of this new method.CPS Compliance Review: This feature flag does not change any behaviour that is described or constrained by our CP/CPS. The closest relation would just be API availability in general.
Fixes #7780