Skip to content

Conversation

@beautifulentropy
Copy link
Member

@beautifulentropy beautifulentropy commented Aug 19, 2025

sfe/forms/fields.go:

  • Define Web UI field types (input, dropdown, textarea, checkbox) that can be declared and rendered as HTML.

sfe/forms/forms.go:

  • Define collections of Web UI fields that can be composed and rendered as HTML.

sfe/overrides.go:

  • Define constants and variables used only for fields and values displayed in the Web UI.
  • Implement field-level validation for override request form fields.
  • Define the forms and fields that make up the override request forms.
  • Add HTTP handlers to render forms, validate individual fields on input, and validate complete submissions.

sfe/sfe.go:

sfe/static/overriderequest.js:

  • Validate fields as they are filled, block submission until all are valid, send the payload to the server, and redirect on success. All requests use a 10s timeout. Timeouts and general errors are shown in a banner; validation errors are shown beside the field.

Closes #8167

@beautifulentropy beautifulentropy changed the title Sfe form building sfe: Add rate limit override request portal Web UI and supporting endpoints Aug 19, 2025
@beautifulentropy beautifulentropy changed the title sfe: Add rate limit override request portal Web UI and supporting endpoints sfe: Add rate limit override request portal Web UI and endpoints Aug 19, 2025
@beautifulentropy beautifulentropy force-pushed the sfe-form-building branch 3 times, most recently from 5915eb6 to 582e882 Compare August 19, 2025 18:46
@beautifulentropy beautifulentropy marked this pull request as ready for review August 19, 2025 19:12
@beautifulentropy beautifulentropy requested a review from a team as a code owner August 19, 2025 19:12
@beautifulentropy beautifulentropy force-pushed the sfe-form-building branch 2 times, most recently from 3aab663 to 905e0e8 Compare August 19, 2025 20:15
@beautifulentropy
Copy link
Member Author

WebUI.mov

@beautifulentropy beautifulentropy changed the base branch from main to remove-go1.24.x August 20, 2025 15:28
Base automatically changed from remove-go1.24.x to main August 20, 2025 19:25
jprenken
jprenken previously approved these changes Aug 22, 2025
@beautifulentropy beautifulentropy merged commit 0e6389d into main Aug 27, 2025
12 checks passed
@beautifulentropy beautifulentropy deleted the sfe-form-building branch August 27, 2025 14:52
beautifulentropy added a commit that referenced this pull request Oct 9, 2025
Also, fix a bug introduced in #8365: set the rateLimit field in Zendesk
tickets for CertificatesPerDomain overrides to include the ipAddr or
dnsName suffixes expected by the overrides importer.

Closes #8360
@aarongable aarongable mentioned this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sfe: Add rate limit override request portal Web UI and supporting endpoints

4 participants