Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to Passages and Sources tables to track embedding model/dimentions #719

Closed
sarahwooders opened this issue Dec 27, 2023 · 1 comment
Assignees

Comments

@sarahwooders
Copy link
Collaborator

We should add metadata fields to the Passages table that include:

  • embedding_model: Model used to generate the embedding (also in Sources table)
  • embedding_dim: Dimensions of embedding field (also in Sources table)
  • num_tokens: Number of tokens contained in passage
  • num_chars: Number of characters contained in passages

This will allow us to add additional checks:

  • When querying archival memory, filter by embedding_model field to avoid
  • Warn users when they change their embedding model, which loaded sources will not longer be accessible to their agent

Deign Decisions

  • When a user change their embedding model, should we remove previously imported embeddings from the agent (as they will still be saved in the data sources table)?
@sarahwooders sarahwooders self-assigned this Dec 27, 2023
Copy link

github-actions bot commented Dec 6, 2024

This issue has been automatically closed due to 60 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant