-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Milvus storage connector #1198
Conversation
5675ade
to
d0f77ff
Compare
@sarahwooders Can you help to review this PR, thanks |
de91fb9
to
60d50fb
Compare
10182fc
to
ef89675
Compare
Could you please make sure you ran poetry lock with Python 3.12 and poetry version 1.8.2? |
@sarahwooders Thank you for reminding me, and I think it's the correct setting now. |
Could you please double check you are using the right versions? It looks like the tests are still failing. |
Hi, @sarahwooders I guess there may be other problems that caused this test to fail. The tests failed due to hash poetry.lock file failing, I don't know what it means, I added milvus dependency in pyproject.toml, and updated poetry.lock file. Does this hash error indicate that I cannot modify the lock file? Or indicate other problems? Can you please help to confirm or provide more information, thanks a lot. |
Could you please give me edit access to your branch, and i can play around with it? Not sure what is causing the error. |
@sarahwooders I have invited you as collaborator into my repo. Thanks for helping to check the problem |
Any progress on the debugging? @sarahwooders |
I added another commit "adapt to milvus lite" where deleted the milvus service starting from docker in githubworkflow file, instead, I use milvus lite to start milvus without any other new shell script. In this way, the hash file problem is fixed. However, there are still some problem with milvus lite, we will try to fix them as soon as possible. |
Signed-off-by: ChengZi <chen.zhang@zilliz.com>
Signed-off-by: ChengZi <chen.zhang@zilliz.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - merging into a staging branch so we can work on fixing some of the tests.
@sarahwooders Thanks for the merging into |
Description
This PR adds support for Milvus - https://milvus.io/docs to be used as an archival storage connector.
Tests
Have tested successfully in local environment for tests/test_storage.py. and tests/test_load_archival.py