Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debug logs in server (#1452) #1457

Merged
merged 4 commits into from
Jun 17, 2024
Merged

fix: debug logs in server (#1452) #1457

merged 4 commits into from
Jun 17, 2024

Conversation

sarahwooders
Copy link
Collaborator

No description provided.

@sarahwooders sarahwooders requested a review from cpacker June 15, 2024 23:10
@norton120
Copy link
Collaborator

norton120 commented Jun 16, 2024

The failing service on that integration test, is that an external service? I can't see any code changes that should have impacted it

NVM I looked at it a little closer and see it's a local instance running from the dev-compose.yaml. service builds and runs fine on my local, I'll tear it down again to be sure there's not a good cache in the way

@norton120
Copy link
Collaborator

The failing service on that integration test, is that an external service? I can't see any code changes that should have impacted it

NVM I looked at it a little closer and see it's a local instance running from the dev-compose.yaml. service builds and runs fine on my local, I'll tear it down again to be sure there's not a good cache in the way

reproduced it, working on it now

@norton120
Copy link
Collaborator

norton120 commented Jun 16, 2024

The issue is a llamaindex dependency conflict >3.12.2, specifically in pydantic:

I'm building it again explicitly with 3.12.2 to confirm that's the issue (it'll take a bit) and hopefully that will solve this run.
this speaks to it #1458

@cpacker cpacker merged commit 09f2e41 into main Jun 17, 2024
11 checks passed
@cpacker cpacker deleted the logger-staging branch June 17, 2024 02:21
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
Co-authored-by: Ethan Knox <ethan.m.knox@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants