Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading data into archival with Llama Index connectors #146

Merged
merged 20 commits into from
Oct 27, 2023
Merged

Support loading data into archival with Llama Index connectors #146

merged 20 commits into from
Oct 27, 2023

Conversation

sarahwooders
Copy link
Collaborator

@sarahwooders sarahwooders commented Oct 26, 2023

Llama Index has implemented a variety of connectors for reading, parsing, and embedding data. This pull request integrates with Llama index to allow users to ingest more data sources into archival memory.

Data can be loaded into archival with the following command

memgpt load <CONNECTOR> --name <DATASET-NAME> [ARGS]

where supported connectors are currently directory and webpage.

Remaining to-dos before merging:

  • Migrate MemGPT to query through LlamaIndex retrievers
  • Add tests for loading into archival storage

@sarahwooders sarahwooders requested a review from cpacker October 27, 2023 00:06
@cpacker
Copy link
Collaborator

cpacker commented Oct 27, 2023

@sarahwooders are there example commands w/ dummy data I can test this with (eg for runtime error on my end)?

@sarahwooders
Copy link
Collaborator Author

It's not fully integrated into the CLI yet, but you can run the tests:

poetry install 
poetry run pytest -s tests

And also make sure memgpt still works OK.

Also just lmk if stylistically it seems OK before I refactor the CLI/config.

@cpacker
Copy link
Collaborator

cpacker commented Oct 27, 2023

@sarahwooders tests passed on my end, but I'm getting:

ModuleNotFoundError: No module named 'llama_index'

when testing backcompat with python main.py.

Should we add llama_index as a default dependency?

@sarahwooders
Copy link
Collaborator Author

Did you run poetry install and then poetry run python main.py? The poetry.lock is updated so you might need to make sure the environment has llama_index.

@cpacker
Copy link
Collaborator

cpacker commented Oct 27, 2023

I am a poetry scrub, I did not run with the poetry prefix

image

@cpacker
Copy link
Collaborator

cpacker commented Oct 27, 2023

Alright LGTM, backcompat looks fine. Will merge when you're back.

Copy link
Collaborator

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👩‍🍳

@sarahwooders sarahwooders merged commit 23e5221 into letta-ai:main Oct 27, 2023
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
Support loading data into archival with Llama Index connectors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants