Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes error when calling function without providing timestamp (even t… #1586

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

Vandracon
Copy link

@Vandracon Vandracon commented Jul 28, 2024

…hough it's marked as optional)

Please describe the purpose of this pull request.
Is it to add a new feature? Is it to fix a bug?

Fixes a bug

How to test
How can we test your PR during review? What commands should we run? What outcomes should we expect?

Send a message to agent via API. But instead of user message, use system. It errors with missing timestamp argument. This small code changed unblocked me. I've done system calls in the past so this must have slipped through recently.

{
"message": "This is a user triggered system alert",
"role": "system",
"stream": true,
"timestamp": "2024-07-20 09:05:18.346725"
}

Have you tested this PR?
Have you tested the latest commit on the PR? If so please provide outputs from your tests.

I was blocked, did this code change, got a success back.

Related issues or PRs
Please link any related GitHub issues or PRs.

Is your PR over 500 lines of code?
If so, please break up your PR into multiple smaller PRs so that we can review them quickly, or provide justification for its length.

Additional context
Add any other context or screenshots about the PR here.

@sarahwooders sarahwooders changed the title Fixes error when calling function without providing timestamp (even t… fix: Fixes error when calling function without providing timestamp (even t… Jul 29, 2024
@sarahwooders sarahwooders self-requested a review July 29, 2024 20:44
Copy link
Collaborator

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@sarahwooders sarahwooders merged commit 7cc4fb0 into letta-ai:main Jul 29, 2024
9 of 13 checks passed
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants