Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validate memory.memory edits + patch bug due to not returning copy of AgentState #1611

Merged
merged 3 commits into from
Aug 5, 2024
Merged

feat: validate memory.memory edits + patch bug due to not returning copy of AgentState #1611

merged 3 commits into from
Aug 5, 2024

Conversation

cpacker
Copy link
Collaborator

@cpacker cpacker commented Aug 5, 2024 •
edited
Loading

Passes tests:

poetry run pytest -sv tests/test_new_client.py

cpacker added 2 commits August 4, 2024 15:54
@cpacker
turn on correct accessors (time to find the bug)
3787d09
@cpacker
refactor memory.py so avoid direct access of memory.memory (use gette…
228220b 
…rs/setters), additionally patch bug derived from not returning a deepcopy of AgentState
@cpacker cpacker requested a review from sarahwooders August 5, 2024 02:21
sarahwooders
sarahwooders approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sarahwooders sarahwooders merged commit 5929813 into refactor-api Aug 5, 2024
5 checks passed
@cpacker cpacker deleted the validate-memory branch August 5, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahwooders sarahwooders sarahwooders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpacker @sarahwooders