Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor agent create function #2054

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

khangich
Copy link

Please describe the purpose of this pull request.
Is it to add a new feature? Is it to fix a bug?

  • simple refactor
  • consolidate repeated logic
  • simplifying conditional

How to test
How can we test your PR during review? What commands should we run? What outcomes should we expect?

Have you tested this PR?
Have you tested the latest commit on the PR? If so please provide outputs from your tests.

Related issues or PRs
Please link any related GitHub issues or PRs.

Is your PR over 500 lines of code?
If so, please break up your PR into multiple smaller PRs so that we can review them quickly, or provide justification for its length.

Additional context
Add any other context or screenshots about the PR here.

@khangich
Copy link
Author

retest please

@khangich
Copy link
Author

@cpacker this is such a simple change, why does the tests complain about keys and other configs? What can I do to move this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant