Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve retry mechanism for _get_ai_reply and refactor method #2113

Merged
merged 4 commits into from
Nov 30, 2024
Merged

feat: Improve retry mechanism for _get_ai_reply and refactor method #2113

merged 4 commits into from
Nov 30, 2024

Conversation

mattzh72
Copy link
Collaborator

Description

Improve retry mechanism for _get_ai_reply and refactor method to improve code quality. We add an exponential backoff, and differentiate between retryable errors v.s. generic errors.

Testing

Rely on existing unit testing.

@mattzh72 mattzh72 requested a review from cpacker November 27, 2024 22:27
cpacker
cpacker approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattzh72 are we sure test_summarize.py (which has the pertenant test test_autosummarize) is actually getting run?

I don't see it in the CI traces and it's not in tests.yml

@cpacker
Copy link
Collaborator

cpacker commented Nov 29, 2024

#2122

@mattzh72 mattzh72 merged commit 1da295a into main Nov 30, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahwooders sarahwooders sarahwooders left review comments

@cpacker cpacker cpacker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattzh72 @cpacker @sarahwooders