feat: Embedded Postgresql #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norton120
had a problem deploying
to
Deployment
GitHub Actions
Failure
norton120
had a problem deploying
to
Deployment
GitHub Actions
Failure
|
Note the SQLite guts are still in there, we'd want to clean that out in a subsequent PR once this is the path forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
This PR embeds Postgres and PgVector binaries into the runtime of the application. The intent is for this embedded db to replace SQLite/Chroma so the project no longer needs to support 2 different backends.
How to test
Start up and run your tests as usual - if no
pg_urior postgres db params are specified as settings, an embedded PG will be started with the server. The database data is stored at<letta_dir>/pgdata. You can connect directly with an ODBC/JDBC tool (like dbeaver or datagrip or whatever) by using the database uri from the logs, which will look like:postgresql://postgres:@/postgres?host=/Users/yourname/.letta/pgdataHave you tested this PR?
When I run the
pytest -s testsI get import errors and warnings on main. I get the same with this branch.QA testing, I have been able to create users and see them populate in the db, but I get 422 errors in the GUI (same as on main).
Related issues or PRs
Related to #2072 which includes pgserver as part of the installable dmg image.