Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support system message for chatml wrapper #2187

Merged
merged 2 commits into from
Dec 7, 2024
Merged

feat: support system message for chatml wrapper #2187

merged 2 commits into from
Dec 7, 2024

Conversation

sarahwooders
Copy link
Collaborator

No description provided.

@sarahwooders sarahwooders requested a review from cpacker December 7, 2024 19:36
cpacker
cpacker approved these changes Dec 7, 2024
View reviewed changes
Copy link
Collaborator

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to do this for all wrappers we use, so including the llama3 one

@sarahwooders sarahwooders merged commit ccf15b3 into main Dec 7, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpacker cpacker cpacker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahwooders @cpacker