Add basic tests that are run on PR/main #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck on only setting the bootup message
cpacker
commented
Nov 1, 2023
tests/test_questionary.py
Outdated
| print("(pre-enter) DEBUG AFTER:", child.after) | ||
| try: | ||
| # child.expect(["Try again!", pexpect.EOF]) | ||
| child.expect("Try again!") |
There was a problem hiding this comment.
@vivi this is where the first fail happens on ubuntu, gets an EOF
cpacker
commented
Nov 1, 2023
tests/test_questionary.py
Outdated
| time.sleep(1.0) # Wait for a short while to let output be captured | ||
| # child.sendline() | ||
| # child.sendline() | ||
| sys.stdout.flush() |
cpacker
changed the title
vivi
changed the title
mattzh72
pushed a commit
that referenced
this pull request
Oct 9, 2024
* make tests dummy to make sure github workflow is fine * black test * strip circular import * further dummy-fy the test * use pexpect * need y * Update tests.yml * Update tests.yml * added prints * sleep before decode print * updated test to match legacy flow * revising test where it fails * comment out enter your message check for now, pexpect seems to be stuck on only setting the bootup message * weird now it's not showing Bootup sequence complete? * added debug * handle none * allow more time * loosen string check * add enter after commands * modify saved compontent snippet * add try again check * more sendlines * more excepts * test passing locally * Update tests.yml * dont clearline * add EOF catch that seems to only happen on github actiosn (ubuntu) but not macos * more eof * try flushing * add strip_ui flag * fix archival_memory_search and memory print output * Don't use questionary for input if strip_ui * Run black * Always strip UI if TEST is set * Add another flush * expect Enter your message * more debug prints * one more shot at printing debug info * stray fore color in stripped ui * tests pass locally * cleanup --------- Co-authored-by: Vivian Fang <hi@vivi.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.