fix: sort json state files by name #736
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorting by name should work, as they are written in timestamp order. Sorting by edit date results in unpredictable behavior when files are moved. Re-enable logging from load_agent
|
closed as local file storage is being wound down |
carenthomas
pushed a commit
that referenced
this pull request
Jan 24, 2025
Co-authored-by: Mindy Long <mindy@letta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorting by name should work, as they are written in timestamp order.
Sorting by edit date results in unpredictable behavior when files are moved.
Re-enable logging from load_agent - unsure how to specifically filter llama noise, but filtering out logging overall made debugging difficult
Please describe the purpose of this pull request.
The fix is to help enable moving memgpt memory
How to test
You can restart an agent and things will function correctly.
Have you tested this PR?
Related issues or PRs
Please link any related GitHub issues or PRs.
Is your PR over 500 lines of code?
If so, please break up your PR into multiple smaller PRs so that we can review them quickly, or provide justification for its length.
Additional context
Add any other context or screenshots about the PR here.