Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semimob patches #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Semimob patches #1

wants to merge 5 commits into from

Commits on Dec 26, 2018

  1. Reuse same popover to preserve scroll offset if needed to present sam… 

    …e picker again
    @elmodos
    elmodos committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    bd63484 View commit details
    Browse the repository at this point in the history

  2. Still present as popover on iPhone if there is enough space around so… 

    …urceRect
    @elmodos
    elmodos committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    6d544f4 View commit details
    Browse the repository at this point in the history

  3. Reusing same picker produces new popover presentation controller, thu… 

    …s setting it before each presentation
    @elmodos
    elmodos committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    3639c0c View commit details
    Browse the repository at this point in the history

  4. Hide skin tone picker on device rotation due to invalid geometry, but… 

    … still looks as good UX
    @elmodos
    elmodos committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    13c65a1 View commit details
    Browse the repository at this point in the history

  5. Crash fix: on iPhone without popover main picker container VC's view … 

    …is removed from hierarcy, thus does not have window. Fixes also by: .overFullScreen (fix for split view controller)
    @elmodos
    elmodos committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    1de23f0 View commit details
    Browse the repository at this point in the history