Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xpath, improve pepxml.roc_curve() #10

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Fix xpath, improve pepxml.roc_curve() #10

merged 1 commit into from
Jul 6, 2020

Conversation

alephreish
Copy link
Contributor

  • Fixes xpath bugs in pepxml.roc_curve() that caused a fatal error [XPathEvalError: Invalid predicate]
  • Adds "charge" and "tag" keys to the output to make the function usable in real world.

Fixes xpath bugs in pepxml.roc_curve() that caused a fatal error [XPathEvalError: Invalid predicate]; adds "charge" and "tag" keys to the output to make the function usable in real world.
@levitsky
Copy link
Owner

levitsky commented Jul 6, 2020

Thank you! This is a legacy function and to be honest I don't think I've ever used it myself.
One minor question: should we maybe convert charge to an integer?

@alephreish
Copy link
Contributor Author

Hi! I wrote my own parser for pepxml in node.js, but recently decided to switch to pyteomics for everyday use - that's when I discovered also roc_curve().
No, "charge" has to remain string as it is a categorical variable and will be used as such in most of the cases. It goes: "all", "2", "3" and "4".

@levitsky
Copy link
Owner

levitsky commented Jul 6, 2020

Ah, OK, thanks.

I'm glad you've found pyteomics to be of use and thank you for the contribution!

@levitsky levitsky merged commit 1aa724b into levitsky:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants