Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A minimal Universal Spectrum Identifier parser and PROXI client #11

Merged
merged 3 commits into from
Oct 6, 2020

Conversation

mobiusklein
Copy link
Contributor

This PR implements a minimal Universal Spectrum Identifier parser and PROXI client to consume USIs and return spectra from Peptide Atlas, MassIVE, PRIDe, and jPOST.

@levitsky
Copy link
Owner

levitsky commented Oct 6, 2020

Thank you! Looks great.

Looking at the test, though, I wonder if there's an easy way to also test the functions without numpy.
Also, not sure how much we should care about Python 2 compatibility at this point, but the <= comparison on dictionary keys seems to have a different meaning there. The tests pass as long as the dicts are equal, of course.

@mobiusklein
Copy link
Contributor Author

You're right, on Py2 dict.keys isn't Set-like. I've fixed that, and removed the dependency on numpy from the test too.

@levitsky
Copy link
Owner

levitsky commented Oct 6, 2020

Ah yes, this is surely the easiest way. I was probably trying to think of something too complex. Thanks again!

@levitsky levitsky merged commit 2a8cef6 into levitsky:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants