feature: add support for ghe #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @codezninja! Thanks for this PR. It looks really straightforward. Just have one question, because I never used GHE: How can we know that it works fine there? Did you have the chance to test it manually? |
|
@matiasalbarello yes I'm currently using this code in a GHE instance. |
ssaunier
reviewed
Apr 6, 2022
ssaunier
reviewed
Apr 6, 2022
Co-authored-by: Sébastien Saunier <seb@lewagon.org>
|
Thanks for @ssaunier fix I confirmed if I don't pass in api_endpoint it fails for me since its on a GHE instance since it is trying to pull from api.github.com |
matiasalbarello
approved these changes
Apr 15, 2022
ssaunier
reviewed
Apr 23, 2022
Co-authored-by: Matias Albarello <1678497+matiasalbarello@users.noreply.github.com>
|
@matiasalbarello @ssaunier sorry for the delay on this. I've made the changes per the review. Please let me know if there's anything else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for GHE instances
Fixes #62