Core code rework #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* shorten if-else branches * replace sys.function, sys.frame, environment with caller_fn, caller_env, fn_env * remove branch with case of caller_env (previously called `e`) being NULL * replace deparse with expr_deparse * function always returns invisibly * add imports of rlang and glue functions to documentation, remove `::` when calling imported function
* rename expression to deparsed_expression to avoid clash with base function * replace passing NULL values for deparsed_expression and x with not passing them at all as NULL values are tricky * replace functions with rlang subsitutes, add imports, reorganize code a little
lewinfox
reviewed
May 10, 2021
lewinfox
reviewed
May 10, 2021
lewinfox
reviewed
May 13, 2021
lewinfox
pushed a commit
that referenced
this pull request
May 13, 2021
Following changes in #1 `ic()` now returns invisibly. Updated README to reflect this.
lewinfox
pushed a commit
that referenced
this pull request
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm proposing a few code changes to core ic code. None of those changes are revolutionary, they are simple refinement. Tests have received small improvements. I've also took the liberty of adding my personal details to the description.
List of changes to
ic:e) being NULL::when calling imported functionList of changes to
ic_print: