Question about on_attach being called early

[tronikelis]

Hello,

I see in the docs it states

Custom mappings can be defined in the on_attach callback

And in the readme I see examples of setting a lot of keymaps in the on_attach callback.

Problem

What does not make sense to me is that at the time of calling vim.keymap or any other keymap adding api, those keymaps wouldn't work, because on_attach is called before actually computing hunks

It's called here

gitsigns.nvim/lua/gitsigns/attach.lua

Line 329 in ac5aba6

if config.on_attach and config.on_attach(cbuf) == false then

But for keymaps to work this update needs to finish

gitsigns.nvim/lua/gitsigns/attach.lua

Lines 366 to 367 in ac5aba6

	-- Initial update
	manager.update(cbuf)

As I understand it now the on_attach is meant to be used to skip attaching to some buffers, so moving it under update wouldn't make sense at this point, thus I propose adding a new config, which I tried to do in this PR #1146

[xzbdmw]

I think GitSignsUpdate would be called after attaching first time (I forgot this autocommand before).

[tronikelis]

Yep, GitSignsUpdate works thanks @xzbdmw , I am closing this then