Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added on_attach_after config option #1146

Closed
wants to merge 1 commit into from

Conversation

tronikelis
Copy link

Why

When trying to navigate to a hunk automatically on some condition, I noticed that on_attach does not work like I thought, it gets called without hunk info.

Thus you need to use vim.defer_fn which is an unstable solution which I dislike nvim-telescope/telescope.nvim#3341 (comment)

@tronikelis
Copy link
Author

Hello, why was this closed? Is there a better way to make nav_hunk work on buffer attach without needing to defer_fn?

@T0nd0Tara
Copy link

@lewis6991 doesn't accept PRs to this repo for some reason. I have also tried to add a feature in #1138.
when I tried contacting him via email he didn't respond...

I don't get why he closed it tho, if it's not good enough I'll fix it, and if it's not the right time I'll wait. But currently he just closes PRs without giving a reason

@tronikelis
Copy link
Author

tronikelis commented Nov 20, 2024

@lewis6991 doesn't accept PRs to this repo for some reason. I have also tried to add a feature in #1138. when I tried contacting him via email he didn't respond...

I don't get why he closed it tho, if it's not good enough I'll fix it, and if it's not the right time I'll wait. But currently he just closes PRs without giving a reason

maybe the API is in a locked state 🤔 if so, putting this on a readme would save a lot of time

@ilan-schemoul
Copy link

maybe the API is in a locked state 🤔 if so, putting this on a readme would save a lot of time

Same thing happened to me. He really should put something in the README for sure. It's frustrating. It's ok to say you only accept bugfix but you want to do code all the features (probably doesn't want to maintain code he doesn't need ?) but you gotta state it upfront.

@lewis6991
Copy link
Owner

Added to CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants