feat: support for statuscolumn #1037
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewis6991
force-pushed
the
feat/statuscolumn
branch
4 times, most recently
from
1f2e274 to
28feeed
Compare
lewis6991
force-pushed
the
feat/statuscolumn
branch
from
28feeed to
87dec80
Compare
luukvbaal
reviewed
Jun 12, 2024
| table.insert(res, '%#' .. s[2] .. '#') | ||
| table.insert(res, s[1]) | ||
| res_len = res_len + vim.str_utfindex(s[1]) | ||
| table.insert(res, '%#NONE#') |
There was a problem hiding this comment.
I think you want %* here to restore the currently active default statuscolumn highlight (affected by cursorline etc). (Unless this does the same?)
| if next(signs.signs) then | ||
| max_pad = 2 | ||
| end | ||
| local marks = api.nvim_buf_get_extmarks(0, signs.ns, { lnum - 1, 0 }, { lnum - 1, -1 }, {}) |
There was a problem hiding this comment.
Suggested change
| local marks = api.nvim_buf_get_extmarks(0, signs.ns, { lnum - 1, 0 }, { lnum - 1, -1 }, {}) | |
| local buf = api.nvim_win_get_buf(vim.g.statusline_winid) | |
| local marks = api.nvim_buf_get_extmarks(buf, signs.ns, { lnum - 1, 0 }, { lnum - 1, -1 }, {}) |
I suppose there is no need to change the function signature like I suggested on matrix.
| api.nvim__redraw({ | ||
| buf = bufnr, | ||
| range = { top, bot }, | ||
| statuscolumn = true, |
There was a problem hiding this comment.
Did you experience that both range and statuscolumn are necessary? The entire window should already be redrawn with statuscolumn = true. But yeah previously placing sign extmarks was what triggered redraws so since that doesn't happen here anymore I think these manual redraws are necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.