fix: derive Staged*Cul highlight correctly #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitSignsStagedTopdeleteCul highlight (especially the foreground) was very hard to read. It seems the issue was that GitSignsStagedTopdeleteCul incorrectly derived from GitSignsStagedChangeCul instead of the expected GitSignsChangedeleteCul. So I think the fg_factor ended up being 0.5 of 0.5 equals .25, foreground extremely dim. Likely just a simply cut-and-paste oversight. With this change the dim problem goes away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GitSignsStagedTopdeleteCulhighlight (especially the foreground) was very hard to read. It seems the issue was thatGitSignsStagedTopdeleteCulincorrectly derived fromGitSignsStagedDeleteCulinstead of the expectedGitSignsTopdeleteCul.So I think the
fg_factorended up being0.5of0.5equals0.25, foreground extremely dim.Likely just a simply cut-and-paste oversight.
With this change the dim problem goes away.